Add all components/directives to module exports #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hii , Is anyboday working on it. if you don't mind i want to fix this one. As I see 9 of 2 completed issue headline. |
|
The pr is done, but need someone from swimlane to look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
All components and directives are not exported
What is the new behavior?
All components and directives are exported
Does this PR introduce a breaking change? (check one with "x")
Other information:
Functionally this makes no difference for consumers of the library. However, we are building some features on top of this table that are very specific to our usecase. In other words, getting our changes into this project is not feasible. We're unable to build our features on top of this table without cloning the repo into our own code. Obviously this is not a good solution in the long-term. By exporting the components, we're able to reuse everything from this library and only override the ones we need. Without exporting them the components are unknown to angular.