Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1559 where disabling scrollbarV in combination with frozenRight will show a transparent gap on the right side #2095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dennis-f
Copy link

@dennis-f dennis-f commented Jun 7, 2022

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
As described in #1559 and also in #2065 there is an offset, when using frozenRight on columns when disabling scrollbarV.

Before:
2022-06-07 17_54_28-ngx-datatable - Angular component for presenting large and complex data

What is the new behavior?
There is no offset to the right anymore

After: 2022-06-07 17_55_00-ngx-datatable - Angular component for presenting large and complex data

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dennis-f dennis-f changed the title Fix 1559 Fix #1559 where disabling scrollbarV in combination with frozenRight will show a transparent gap on the right side Jun 8, 2022
… the offset, as offset already considers scrollbarWidth
@dennis-f
Copy link
Author

tumbleweed-crickets-chirping

@SHUBHAMDAVE001
Copy link

Is this merged in main branch ?
I am facing same issue after pulling updated version.
Please let me know how to fix this issue.

Thanks in Advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants