Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor animated image cache deletion #248

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qbnu
Copy link
Contributor

@qbnu qbnu commented Oct 8, 2023

No description provided.

@sylikc
Copy link
Owner

sylikc commented Oct 9, 2023

Ha. You beat me to it. And your solution is done more elegantly than what I had in mind.

I'm pretty sure it was the delete jxl and stuff that caused the PSD block not to work, because those sections are subbed out. I'll put the ifdef in the right places when I try another XP build

@sylikc
Copy link
Owner

sylikc commented Oct 16, 2023

Do you want to undraft this one or is there more changes you're doing for cache fixes?

@qbnu
Copy link
Contributor Author

qbnu commented Oct 19, 2023

@sylikc I haven't actually tested this, and I'll probably refactor more stuff later

@sylikc
Copy link
Owner

sylikc commented Nov 23, 2023

Ok, yeah I wanted to try to look at the "fallback detection" idea that I had. It touches the same code as the cache cleanup, so I can test this when I develop or just merge it if you've used it.

My idea is to add an option as to what other methods to try to fallback when an image isn't properly loaded. It would address a behavior that I reported to remind myself #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants