Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused code in AnnotatedString #246

Closed
wants to merge 1 commit into from

Conversation

vmartinv
Copy link
Contributor

@vmartinv vmartinv commented Nov 4, 2023

I think these functions are not used anymore after the latest refactor. The reason I want to remove it is because I'll be adding a bunch of tests to improve coverage, and this code is not really reachable.

I also correct an error in a comment's example (Range.overlaps uses exclusive ending ranges).

@sylvainhalle
Copy link
Owner

I thank you but if you don't mind I'd leave this specific PR on hold for now. In fact I'd eventually like to move AnnotatedString back into the Petit Poucet library instead of TeXtidote, and to do so it is important that the class implements ExplanationQueryable.

@vmartinv
Copy link
Contributor Author

vmartinv commented Nov 6, 2023

Got it, then it won't hurt to keep it. Maybe I will add some tests later.

@vmartinv vmartinv closed this Nov 6, 2023
@vmartinv vmartinv deleted the cleanup_as branch November 7, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants