[Store] Add Meilisearch #105

Guikingone · 2025-07-12T17:20:23Z

Q	A
Bug fix?	no
New feature?	yes
Docs?	yes
Issues	Fix #93
License	MIT

Hi 👋🏻

As explained in #93, this PR aim to add meilisearch as a vector store, the full integration is not finished (tests to be validated) but the main implementation is ready.

chr-hertel

Hey @Guikingone, thanks for jumping on that and providing the first commits :) 👍

In general it looks good already and i think going with the API directly is a good and lightweight idea 👍

I left a couple of comments and was wondering, if we can ease the usage of the example here. were you using the cloud or a docker container of meilisearch?

I think, if reasonable to you as well, it would be great to extend the docker compose setup of the example to bring in meilisearch there.

and please add docs and a test for the Store class

examples/store/meilisearch-similarity-search.php

src/store/src/Bridge/Meilisearch/Store.php

examples/store/meilisearch-similarity-search.php

Guikingone · 2025-07-13T09:49:26Z

Hi @chr-hertel 👋🏻

The PR is fixed, the CI fails due to a zip error (not on unit tests side), the store is improved and tested 🙂

src/store/doc/index.rst

chr-hertel · 2025-07-13T10:27:50Z

Thanks for the update and especially the docker changes - now I can easily run it, but I get this error while executing the example:

php store/meilisearch-similarity-search.php
PHP Fatal error:  Uncaught Symfony\Component\HttpClient\Exception\InvalidArgumentException: Invalid URL: scheme is missing in "indexes". Did you forget to add "http(s)://"? in /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/HttpClientTrait.php:580
Stack trace:
#0 /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/HttpClientTrait.php(178): Symfony\Component\HttpClient\CurlHttpClient::resolveUrl()
#1 /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/CurlHttpClient.php(100): Symfony\Component\HttpClient\CurlHttpClient::prepareRequest()
#2 /home/christopher/Projects/SymfonyAI/repo/src/store/src/Bridge/Meilisearch/Store.php(72): Symfony\Component\HttpClient\CurlHttpClient->request()
#3 /home/christopher/Projects/SymfonyAI/repo/examples/store/meilisearch-similarity-search.php(64): Symfony\AI\Store\Bridge\Meilisearch\Store->initialize()
#4 {main}
  thrown in /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/HttpClientTrait.php on line 580

i'm just using the default values you provided with the .env file

Guikingone · 2025-07-13T11:24:49Z

Ah yes, forgot to call request method during the index initialization, the clients wasn't fully configured and the error occurred when you've called initialize, it should be better now 🙂

chr-hertel · 2025-07-13T14:13:43Z

Yes, that works better - now I'm getting this error:

Invalid value type at .hybrid.semanticRatio: expected a number, but found a string: "1.0"

which refers to this: https://github.com/symfony/ai/pull/105/files#diff-969e7ab9dcae7946fdb6f82fcc866bb86e4389e23e3d40b752e3976de997dd09R58

after fixing this, i get the next one:

Cannot find embedder with name default.

Looks like I'm doing something wrong while running the example or is it also failing for you?

Guikingone · 2025-07-13T15:05:14Z

Ah yes, forgot about the initialization of an embedder in initialize, I added the dimensions as constructor argument (required as we don't know which model is used by the end user).

chr-hertel · 2025-07-13T17:34:49Z

@Guikingone so the provided example runs locally for you and is functional?

Guikingone · 2025-07-13T17:37:36Z

Yes, works locally (I failed to see the indexes embeddings as my local indexes were already configured) 🙂

However, I can't run the script in examples, I need to create a new file 🤔

Thanks for the update and especially the docker changes - now I can easily run it, but I get this error while executing the example:

php store/meilisearch-similarity-search.php
PHP Fatal error:  Uncaught Symfony\Component\HttpClient\Exception\InvalidArgumentException: Invalid URL: scheme is missing in "indexes". Did you forget to add "http(s)://"? in /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/HttpClientTrait.php:580
Stack trace:
#0 /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/HttpClientTrait.php(178): Symfony\Component\HttpClient\CurlHttpClient::resolveUrl()
#1 /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/CurlHttpClient.php(100): Symfony\Component\HttpClient\CurlHttpClient::prepareRequest()
#2 /home/christopher/Projects/SymfonyAI/repo/src/store/src/Bridge/Meilisearch/Store.php(72): Symfony\Component\HttpClient\CurlHttpClient->request()
#3 /home/christopher/Projects/SymfonyAI/repo/examples/store/meilisearch-similarity-search.php(64): Symfony\AI\Store\Bridge\Meilisearch\Store->initialize()
#4 {main}
  thrown in /home/christopher/Projects/SymfonyAI/repo/examples/vendor/symfony/http-client/HttpClientTrait.php on line 580

i'm just using the default values you provided with the .env file

How are you running this file? Any error on the autoload? 🤔

chr-hertel · 2025-07-13T17:48:18Z

like this:

And the underlying issue that OpenAI returns is

This model's maximum context length is 128000 tokens. However, your messages resulted in 281690 tokens (281645 in the messages, 45 in the functions). Please reduce the length of the messages or functions.

Due to the fact that the vectors are part of the payload. Might be rather a design flaw of the SimiliaritySearch feature than your implementation tho 🤔

Was just wondering if it's only me, or if the example works for you

Guikingone · 2025-07-13T17:52:51Z

Strange, if I try to run the script from examples, here's my error:

Regarding the issue with OpenAI, that seems strange, I'll take a look, maybe I missed something 🤔

chr-hertel · 2025-07-13T18:16:14Z

Ah, I know that one, that should've been documented, sorry - see #112

The issue is that Composer is installing the dependencies from main currently and therefore your new class is not available. Meaning, after composer install you can run ../link to bring in your locally changed code

chr-hertel · 2025-07-13T18:19:39Z

Oh, and that's blocked by #108 🙈 - a bit rough here still :D

OskarStark · 2025-07-13T18:49:55Z

src/store/tests/Bridge/Meilisearch/StoreTest.php

+#[CoversClass(Store::class)]
+final class StoreTest extends TestCase
+{
+    public function testStoreCannotInitializeOnInvalidResponse(): void


Remove all void return types in tests please

but why @OskarStark?

it looks like it's common in symfony/symfony but that also supports other versions of PHP and PHPUnit I guess

Yes, not to mention that PHPStan doesn't like when return types are not specified 😄

It's just, that it does not add any value in tests.

Well, I get that there is no functional value, but same is true for the public keyword for test methods.

I get that in combination with supporting various versions and having merge conflicts for nothing but coding best practices is annoying for symfony/symfony - but we don't have that struggle here. so for me adding return type declarations is a best practice to opt-out for reasons, but i see no reason here.

i'd vote for keeping them in

Let's do it

Guikingone requested review from chr-hertel and Nyholm as code owners July 12, 2025 17:20

Guikingone changed the title ~~feat(store): meilisearch store started~~ [Store] Meilisearch store Jul 12, 2025

chr-hertel requested changes Jul 12, 2025

View reviewed changes

chr-hertel added Status: Needs Work Store Issues & PRs about the AI Store component labels Jul 12, 2025

Guikingone force-pushed the store/meilisearch branch from 156caae to a41118c Compare July 13, 2025 09:43

OskarStark changed the title ~~[Store] Meilisearch store~~ [Store] Add Meilisearch Jul 13, 2025

feat(store): meilisearch store started

2827164

Guikingone force-pushed the store/meilisearch branch from a41118c to 2827164 Compare July 13, 2025 09:45

refactor(store): meilisearch store improved

8e5d0d3

chr-hertel reviewed Jul 13, 2025

View reviewed changes

src/store/doc/index.rst Outdated Show resolved Hide resolved

Guikingone added 2 commits July 13, 2025 13:20

fix(store): meilisearch store initialization fixed

daea7d7

fix(store): meilisearch store initialization fixed

257f998

fix(store): store improved to configure index embedders

496e38e

OskarStark reviewed Jul 13, 2025

View reviewed changes

fix(store): extra return types removed

e762a20

Uh oh!

[Store] Add Meilisearch #105

Are you sure you want to change the base?

[Store] Add Meilisearch #105

Conversation

Guikingone commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chr-hertel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Guikingone commented Jul 13, 2025

Uh oh!

Uh oh!

chr-hertel commented Jul 13, 2025

Uh oh!

Guikingone commented Jul 13, 2025

Uh oh!

chr-hertel commented Jul 13, 2025

Uh oh!

Guikingone commented Jul 13, 2025

Uh oh!

chr-hertel commented Jul 13, 2025

Uh oh!

Guikingone commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chr-hertel commented Jul 13, 2025

Uh oh!

Guikingone commented Jul 13, 2025

Uh oh!

chr-hertel commented Jul 13, 2025

Uh oh!

chr-hertel commented Jul 13, 2025

Uh oh!

OskarStark Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

chr-hertel Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Guikingone Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

OskarStark Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

chr-hertel Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

OskarStark Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Guikingone commented Jul 12, 2025 •

edited

Loading

Guikingone commented Jul 13, 2025 •

edited

Loading

chr-hertel Jul 13, 2025 •

edited

Loading