[Store] Add Neo4j #183
Merged
[Store] Add Neo4j #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
OskarStark
reviewed
Jul 22, 2025
OskarStark
added
Store
chr-hertel
reviewed
Jul 24, 2025
chr-hertel
requested changes
Jul 24, 2025
|
@chr-hertel Totally, I'm almost done with the tests, one still tricky, need a few hours on it and this PR should be good, sorry for the delay. |
chr-hertel
reviewed
Jul 27, 2025
OskarStark
reviewed
Jul 28, 2025
OskarStark
reviewed
Jul 28, 2025
|
Just to add context, the tests are not built around "failure / success" as the neo4j API handle things differently, if an index / document already exist, the operation is not performed but |
chr-hertel
approved these changes
Jul 29, 2025
|
Thank you @Guikingone. |
OskarStark
added a commit
that referenced
this pull request
Aug 1, 2025
…e (chr-hertel) This PR was merged into the main branch. Discussion ---------- [Examples] Fix OpenAI and GPT namespaces in Neo4j RAG example | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Follow up after #217 and #183 Commits ------- 7770885 Fix OpenAI and GPT namespaces in Neo4j RAG example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
This PR aim to introduce the
Neo4Jstore as a vector store, the full implementation is based around the HTTP client and, the PR is not fully ready, unit tests must be completed.