Skip to content

[MCP Bundle] Add tests for mcp.page_size parameter #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jul 30, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues --
License MIT

This adds tests for the pagination functionality that was introduced in PR #227.

@OskarStark OskarStark marked this pull request as draft July 30, 2025 12:33
@OskarStark OskarStark force-pushed the test/add-pagination-parameter-tests branch 6 times, most recently from 2599aff to e52fcff Compare July 31, 2025 06:49
@OskarStark OskarStark marked this pull request as ready for review July 31, 2025 07:20
This extends the existing McpBundleTest with tests that verify:
- The default page_size parameter (20) is correctly set
- Custom page_size configuration works properly
- ResourceListHandler and PromptListHandler services are not yet registered

The tests show that pagination configuration is already implemented in the
bundle through the page_size parameter, which defaults to 20 and can be
customized via bundle configuration.
@OskarStark OskarStark force-pushed the test/add-pagination-parameter-tests branch from e52fcff to b584484 Compare July 31, 2025 07:21
@OskarStark OskarStark changed the title [MCP Bundle] Add tests for pagination parameter functionality [MCP Bundle] Add tests for mcp.page_size parameter Jul 31, 2025
@chr-hertel
Copy link
Member

Thank you @OskarStark.

@chr-hertel chr-hertel merged commit 3e8a0b8 into symfony:main Aug 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants