[Platform] Enhance in memory platform to support all ResultInterface types
#252
+72
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamyHakam
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
RamyHakam
force-pushed
the
Enhance-InMemoryPlatform-to-support-all-ResultInterface-types
branch
from
a8c3a8f to
a5e6fa0
Compare
chr-hertel
requested changes
Aug 3, 2025
Comment on lines
36
to
46
| public function invoke(Model $model, array|string|object $input, array $options = []): ResultPromise | ||
| { | ||
| $resultText = $this->mockResult instanceof \Closure | ||
| ? ($this->mockResult)($model, $input, $options) | ||
| : $this->mockResult; | ||
| if ($this->mockResult instanceof \Closure) { | ||
| $result = ($this->mockResult)($model, $input, $options); | ||
|
|
||
| if ($result instanceof ResultInterface) { | ||
| return new ResultPromise( | ||
| static fn () => $result, | ||
| rawResult: $result->getRawResult() ?? new InMemoryRawResult( | ||
| ['text' => $result->getContent()], | ||
| ), | ||
| options: $options | ||
| ); | ||
| } | ||
|
|
||
| $resultText = (string) $result; | ||
| } else { | ||
| $resultText = $this->mockResult; | ||
| } | ||
|
|
||
| $textResult = new TextResult($resultText); | ||
|
|
There was a problem hiding this comment.
Make sense, yes, but would like to see the code less complex please.
For example this could also work, right?
public function invoke(Model $model, array|string|object $input, array $options = []): ResultPromise
{
$result = is_string($this->mockResult) ? $this->mockResult : ($this->mockResult)($model, $input, $options);
if ($result instanceof ResultInterface) {
return $this->createPromise($result, $options);
}
return $this->createPromise(new TextResult($result), $options);
}
private function createPromise(ResultInterface $result, array $options): ResultPromise
{
$rawResult = $result->getRawResult() ?? new InMemoryRawResult(
['text' => $result->getContent()],
(object) ['text' => $result->getContent()],
);
return new ResultPromise(static fn () => $result, $rawResult, $options);
}There was a problem hiding this comment.
You are right, that is simpler and less complex
fabpot
changed the title
ResultInterface typesResultInterface types
chr-hertel
approved these changes
Aug 4, 2025
fabpot
changed the title
ResultInterface typesResultInterface types
chr-hertel
force-pushed
the
Enhance-InMemoryPlatform-to-support-all-ResultInterface-types
branch
from
d00b887 to
82e873f
Compare
|
Thank you @RamyHakam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the existing
InMemoryPlatformto support allResultInterfacetypes, making it easier to test all result types.Previously limited to text responses, it now supports vectors, images, binary data, choices, and any custom result types.