[AIBundle] fix missing endpoint for Meilisearch store #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
OskarStark
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing endpoint configuration for the Meilisearch store in the AI Bundle. The endpoint parameter was not being passed to the MeilisearchStore class constructor, causing configuration issues.
- Adds required endpoint configuration option to the Meilisearch store configuration schema
- Updates service definition to include endpoint parameter in constructor arguments
- Adjusts argument positions for optional parameters to accommodate the new endpoint argument
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ai-bundle/config/options.php | Adds endpoint configuration option to Meilisearch store schema |
| src/ai-bundle/src/AiBundle.php | Updates constructor arguments to include endpoint and reorders optional parameters |
| src/ai-bundle/tests/DependencyInjection/AiBundleTest.php | Adds endpoint configuration to test setup |
OskarStark
approved these changes
Aug 6, 2025
|
Thank you @Guikingone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
A small fix for the meilisearch store, the endpoint was not sent, tests fixed.