Skip to content

chore: allow mongodb/mongodb 2.0 (#341) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

chore: allow mongodb/mongodb 2.0 (#341) #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

env:
REQUIRED_PHP_EXTENSIONS: 'mongodb'

jobs:
php:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -57,6 +60,7 @@ jobs:
with:
php-version: ${{ matrix.php-version }}
tools: flex
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"

- name: Install root dependencies
run: composer install
Expand Down
5 changes: 1 addition & 4 deletions src/store/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,9 @@
"symfony/uid": "^6.4 || ^7.1",
"webmozart/assert": "^1.11"
},
"conflict": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to keep it?

Copy link
Contributor

@OskarStark OskarStark Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean, we now support ^1.21 and ^2.0, so both work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the fact that we don’t test with MongoDB < 1.21, but we don’t forbid to install it anymore.

"mongodb/mongodb": "<1.21"
},
"require-dev": {
"codewithkyrian/chromadb-php": "^0.2.1 || ^0.3 || ^0.4",
"mongodb/mongodb": "^1.21",
"mongodb/mongodb": "^1.21 || ^2.0",
"phpstan/phpstan": "^2.0",
"phpstan/phpstan-webmozart-assert": "^2.0",
"phpunit/phpunit": "^11.5",
Expand Down