Skip to content

feat: add Postgres store #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #...
License MIT

Here is a first/naive attempt to add a Postgres store (via pgvector extension)

Very inspired by the MariaDB store PR (and existing examples).

Trying to digg in the repository, please tell me if anything is not in the spirit/style of what you guys building here..

@smnandre smnandre changed the title [Store] Postgres store feat: add Postgres store Jun 29, 2025
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sind Tests would be nice 🙃

@chr-hertel
Copy link
Contributor

Looks really good - thanks @smnandre! Needs a rebase and Oskar's comments - good to merge than

@chr-hertel chr-hertel added the Store Issues & PRs about the AI Store component label Jun 30, 2025
@smnandre
Copy link
Member Author

smnandre commented Jul 1, 2025

Done :)

@OskarStark
Copy link
Contributor

to keep the flow straight forward, I would love, if you could squash your commits and create a PR on the original llm-chain lib. We can cherry-pick then afterwards

@smnandre
Copy link
Member Author

smnandre commented Jul 2, 2025

Wait, so .. i must have two separated forks, work on AI, rename paths but also concepts from one to the other, open the PR on LLM, and then it's done here ? :|

Could we ease that process a bit?

@smnandre
Copy link
Member Author

smnandre commented Jul 2, 2025

(rebased and squashed here)

@OskarStark
Copy link
Contributor

A right, you must rename the namespaces and so on, didn't thought about this. Ok then nvm, let's merge it here

@chr-hertel
Copy link
Contributor

This is great - thanks for adding that @smnandre 🙏

@smnandre smnandre requested a review from chr-hertel July 7, 2025 23:06
@chr-hertel
Copy link
Contributor

Thanks @smnandre.

@chr-hertel chr-hertel merged commit 4807521 into symfony:main Jul 7, 2025
@chr-hertel chr-hertel deleted the postgres-store branch July 7, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Store Issues & PRs about the AI Store component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants