Skip to content

fix: profiler when tool params are missing description #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

chr-hertel
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Docs? no
Issues
License MIT

Cherry picking php-llm/llm-chain-bundle#100

image

@chr-hertel chr-hertel requested a review from Nyholm as a code owner July 4, 2025 20:41
@chr-hertel chr-hertel added the AI Bundle Issues & PRs about the AI integration bundle label Jul 4, 2025
@OskarStark
Copy link
Contributor

I am against adding the (#100) in the in the PR title, as they will soon link to the wrong PR/issue, because it will take symfony/ai repo into account in the commit history.

@chr-hertel chr-hertel changed the title fix: profiler when tool params are missing description (#100) fix: profiler when tool params are missing description Jul 4, 2025
@chr-hertel
Copy link
Contributor Author

I am against adding the (#100) in the in the PR title, as they will soon link to the wrong PR/issue, because it will take symfony/ai repo into account in the commit history.

yup, good catch, i usually try to remove them - it's an artifact of the cherry pick since it's in the commit message.

@chr-hertel chr-hertel merged commit b03150d into main Jul 4, 2025
24 checks passed
@chr-hertel chr-hertel deleted the bundle-fix-profiler-tool-params branch July 4, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Bundle Issues & PRs about the AI integration bundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants