fix example scripts for docker, class names and env var names #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
tests-example
branch
4 times, most recently
from
34ad989 to
a9f261a
Compare
OskarStark
reviewed
Jul 8, 2025
OskarStark
approved these changes
Jul 8, 2025
xabbuh
reviewed
Jul 8, 2025
| to test these examples. | ||
|
|
||
| ```bash | ||
| docker compose up -d |
There was a problem hiding this comment.
Suggested change
| docker compose up -d | |
| cd examples | |
| docker compose up -d |
There was a problem hiding this comment.
Thanks, yes, we should be explicit here.
I added a section above since this is also true for the composer install and example execution part.
OskarStark
changed the title
|
Thank you @chr-hertel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically fixing some left overs after cherry picking and merging