[AI Store] Remove the Assert library #86
Draft
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Jul 11, 2025
| @@ -24,6 +23,6 @@ public function __construct( | |||
| public string $content, | |||
| public Metadata $metadata = new Metadata(), | |||
| ) { | |||
| Assert::stringNotEmpty(trim($this->content)); | |||
| '' !== trim($this->content) || throw new \InvalidArgumentException('The content shall not be an empty string'); | |||
There was a problem hiding this comment.
Let's be more explicit and do
if ('' === trim($this->content)) {
throw new \InvalidArgumentException('The content shall not be an empty string');
}
|
yes, agree as well, but for the Platform component you'd need to replace more code - or keep it for now and only take action on store |
|
Yes indeed. I will continue this PR when I get back home on Thursday. |
chr-hertel
added
Store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am not sure w need the
webmozart/assertdependency for just one verification.Let me squash this PR before any action (I am not with my usual setup at the moment).
Regards.