[Platform] Use $_SERVER instead of $_ENV
#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on many PHP distribution (for example on ubuntu), [`variables_order` ini setting](https://www.php.net/manual/en/ini.core.php#ini.variables-order) does not include `E` flag: ``` php -i | grep variables_order variables_order => GPCS => GPCS ``` So this script: ``` echo 'env(VAR): ' . ($_ENV['VAR'] ?? 'not set'); echo "\n"; echo 'server(VAR): ' . ($_SERVER['VAR'] ?? 'not set'); echo "\n"; ``` outputs: ```console $ VAR=hello php test.php env(VAR): not set server(VAR): hello ```
welcoMattic
approved these changes
Jul 11, 2025
|
Could also be updated here https://github.com/symfony/ai/blob/main/src/platform/doc/index.rst?plain=1#L36 |
|
@welcoMattic This is already included in the PR: https://github.com/symfony/ai/pull/92/files#diff-c391100c684337820ecf54ead222f452862ec0e410853627752c289e9e259c1b |
|
My bad, missed it 🙈 |
chr-hertel
approved these changes
Jul 11, 2025
OskarStark
changed the title
$_SERVER instead of $_ENV
OskarStark
approved these changes
Jul 11, 2025
|
Thank you @lyrixx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on many PHP distribution (for example on ubuntu),
variables_orderini setting does not includeEflag:So this script:
outputs: