[AiBundle][McpBundle] Upgrade bundle structure #94
+817
−879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
changed the title
welcoMattic
added
AI Bundle
|
Still work to do... |
yceruto
force-pushed
the
bundle_structure
branch
6 times, most recently
from
ada9cc4 to
5befa8b
Compare
|
This is ready for review! |
chr-hertel
approved these changes
Jul 12, 2025
There was a problem hiding this comment.
This looks great & I'm actually learning stuff here - thanks for that @yceruto! :)
|
Did you by any chance try to use |
yceruto
force-pushed
the
bundle_structure
branch
3 times, most recently
from
2bcb267 to
1f21a9d
Compare
|
@chr-hertel I already did that, but GitHub still shows them as new files instead of recognizing them as moved |
chr-hertel
force-pushed
the
bundle_structure
branch
from
1f21a9d to
e61d72d
Compare
|
Thank you @yceruto. |
This was referenced Jul 12, 2025
[AiBundle] Use model FQCN for indexer config, to allow any
Symfony\AI\Platform\Model child class
#88
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the configuration system for AI-related bundles. It replaces the
Configuration.phpfiles with newoptions.phpfiles, streamlining the definition of configuration options. Additionally, it removes exclusions from PHPStan analysis for the deletedConfiguration.phpfiles.Configuration System Overhaul:
src/ai-bundle/config/options.php: Introduced a new configuration file to define options for AI platforms, agents, stores, and indexers. This replaces the previousConfiguration.phpfile with a more concise and flexible structure.src/mcp-bundle/config/options.php: Added a new configuration file for MCP bundle options, including client transport settings and application metadata.Removal of Legacy Files:
src/ai-bundle/src/DependencyInjection/Configuration.php: Removed the old configuration file that defined options for AI platforms, agents, stores, and indexers. Its functionality has been replaced by the newoptions.phpfile.PHPStan Analysis Updates:
src/ai-bundle/phpstan.dist.neon: Removed the exclusion ofConfiguration.phpfrom PHPStan analysis, as the file has been deleted.src/mcp-bundle/phpstan.dist.neon: Similarly, removed the exclusion ofConfiguration.phpfrom PHPStan analysis for the MCP bundle.