Update security.rst related to stateless JS csrf #21293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Comment on lines
+1024
to
+1026
| the ``data-controller`` part is related to the usage of | ||
| https://symfony.com/doc/current/security/csrf.html#generating-csrf-token-using-javascript | ||
| It can be removed if you use statefull session storage, not stateless. |
There was a problem hiding this comment.
I don't think it's useful to hint this can be removed. But it's always good to explain why the attribute is here:
Suggested change
| the ``data-controller`` part is related to the usage of | |
| https://symfony.com/doc/current/security/csrf.html#generating-csrf-token-using-javascript | |
| It can be removed if you use statefull session storage, not stateless. | |
| The ``data-controller`` attribute is needed for [internal link here, not absolute URL]. |
There was a problem hiding this comment.
yes I agree, I can rework it if its accepted
my point was mostly to document why this data attribute is here in the doc (and also on console maker processes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.