FIX: Homebox SVG logo missing in Safari due to size not specified

[katosdev]

Fixes #360

Summary by CodeRabbit

• New Features
  • Explicitly defined height and width attributes for the SVG logo, enhancing clarity and standardization.
• Bug Fixes
  • Removed commented-out dimensions in the style attribute for better browser recognition.

[coderabbitai]

Walkthrough

The pull request addresses an issue with the SVG logo in Safari by explicitly adding height and width attributes to the <svg> element in the Logo.vue component. This change ensures that the logo is correctly rendered across different browsers, specifically resolving a rendering problem in Safari by specifying the exact dimensions of 250px for both height and width.

Changes

File	Change Summary
frontend/components/App/Logo.vue	Added explicit height="250px" and width="250px" attributes to the SVG element

Assessment against linked issues

Objective	Addressed	Explanation
Fix SVG logo rendering in Safari [#360]	✅

Security Recommendations

1. SVG Attribute Validation: Ensure that the hardcoded dimensions are sanitized and do not introduce any potential XSS vulnerabilities.
2. Cross-Browser Compatibility: Verify that the added attributes work consistently across different browser versions and platforms.
3. Accessibility: Consider adding role and aria-label attributes to improve screen reader support for the logo SVG.

Possibly related PRs

• Update Logo.vue #400: Similar changes to SVG logo attributes in Logo.vue

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/components/App/Logo.vue (1)

3-4: Use responsive SVG dimensions for better rendering across devices

By hardcoding the height and width of the SVG, you might inadvertently impact responsiveness on smaller screens. Consider making the SVG dimensions responsive (e.g., using percentage values or the “viewBox” attribute alone) to ensure that it adapts to various screen sizes and maintains its aspect ratio.

Additionally, from a security standpoint, always ensure that any external or inline SVG content is trusted or sanitized to prevent malicious code embedded within the XML.

Would you like suggestions on implementing responsive design for the SVG or a security scanning script to validate that this and other SVG files are safe?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ae1115 and 97e0816.

📒 Files selected for processing (1)

• frontend/components/App/Logo.vue (1 hunks)

[tankerkiller125]

So long as we're sure that Apple actually lost this time