forked from apache/parquet-java
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PARQUET-341 improve write performance for wide schema sparse data
In write path, when there are tons of sparse data, most of time is spent on writing nulls. Currently writing nulls has the same code path as writing values, which is reclusive traverse all the leaves when a group is null. Due to the fact that when a group is null all the leaves beneath it should be written with null value with the same repetition level and definition level, we can eliminate the recursion call to get the leaves This PR caches the leaves for each group node. So when a group node is null, their leaves can be flushed with null values directly. We tested it with a really wide schema on one of our production data. It improves the performance by ~20% Author: Tianshuo Deng <[email protected]> Closes apache#247 from tsdeng/flush_null_directly and squashes the following commits: 253f2e3 [Tianshuo Deng] address comments 8676cd7 [Tianshuo Deng] flush null directly to leaves
- Loading branch information
Showing
2 changed files
with
36 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters