feat(ci): improve ci #327
Open
feat(ci): improve ci #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CeciliaZ030
temporarily deployed
to
test-environment
GitHub Actions
Inactive
CeciliaZ030
temporarily deployed
to
test-environment
GitHub Actions
Inactive
CeciliaZ030
temporarily deployed
to
test-environment
GitHub Actions
Inactive
CeciliaZ030
temporarily deployed
to
test-environment
GitHub Actions
Inactive
petarvujovic98
requested changes
Jul 29, 2024
Comment on lines
+46
to
+57
| env: | ||
| TARGET: ${{ inputs.version_name }} | ||
| run: make install | ||
|
|
||
| - name: Build ${{ inputs.version_name }} prover | ||
| env: | ||
| TARGET: ${{ inputs.version_name }} | ||
| run: make build | ||
|
|
||
| - name: Test ${{ inputs.version_name }} prover | ||
| env: | ||
| TARGET: ${{ inputs.version_name }} |
There was a problem hiding this comment.
Why do we need this env passed when it is already present at line 24?
Comment on lines
+21
to
+37
| - name: Run clippy check host | ||
| run: cargo clippy -p raiko-host -p raiko-lib -p raiko-core -p harness -p raiko-tasks --all-features -- -D warnings | ||
| - name: Run clippy check risc0 | ||
| run: | | ||
| cargo clippy -p risc0-builder --all-features -- -D warnings | ||
| cargo clippy -p risc0-driver --features enable -- -D warnings | ||
| cd ./provers/risc0/guest | ||
| cargo clippy --all-features -- -D warnings | ||
| - name: Run clippy check sp1 | ||
| run: | | ||
| cargo clippy -p sp1-builder --all-features -- -D warnings | ||
| cargo clippy -p sp1-driver --features enable -- -D warnings | ||
| cd ./provers/sp1/guest | ||
| cargo clippy --all-features -- -D warnings | ||
| - name: Run clippy check sgx | ||
| run: | | ||
| cargo clippy -p sgx-guest -p sgx-prover -p raiko-setup --all-features -- -D warnings |
There was a problem hiding this comment.
There needs to be an install step because clippy will still compile the projects so they can't actually compile without the tooling present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.