Skip to content

Allow _ before numbers during candidate extraction #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

Allow _ before numbers during candidate extraction #17961

merged 3 commits into from
May 9, 2025

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented May 9, 2025 •
edited
Loading

This PR fixes a bug where a class like header_1 wasn't properly extracted because we didn't allow an _ before a number.

This PR fixes that by allowing an _ before a number.

Fixes: #17960

Test plan

  1. Added a test to verify this works
  2. Existing tests work

Used the visualizer tool for this to verify that the header_1 class is being extracted:
image

@RobinMalfait RobinMalfait requested a review from a team as a code owner May 9, 2025 16:24
@RobinMalfait RobinMalfait enabled auto-merge (squash) May 9, 2025 16:27
@RobinMalfait RobinMalfait merged commit 737994b into main May 9, 2025
7 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-17960 branch May 9, 2025 16:29
@RobinMalfait RobinMalfait mentioned this pull request May 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@utility won't generate some class names
2 participants
@RobinMalfait @philipp-spiess