Upgrade lightningcss to 1.30.0
#17979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
philipp-spiess
commented
May 12, 2025
•
philipp-spiess
commented
- Fixes #17556
philipp-spiess
force-pushed
the
chore/lightningcss
branch
from
a40dfd5 to
779f2fb
Compare
philipp-spiess
force-pushed
the
chore/lightningcss
branch
from
779f2fb to
3c0d44c
Compare
RobinMalfait
changed the title
1.20.01.30.0
Comment on lines
+5289
to
+5291
| .shadow-xl { | ||
| box-shadow: var(--tw-inset-shadow), var(--tw-inset-ring-shadow), var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow); | ||
| } |
There was a problem hiding this comment.
Interesting, what happened here 🤔
There was a problem hiding this comment.
I think this is fixing an issue in ordering where previously the --tw-shadow could sometimes appear after the box-shadow assignment because of how @supports was resolved. This generates more code now but it's corrent in a sense that even if the supports query works, the assignment is in the right order still.
There was a problem hiding this comment.
Yeah that's fair, just an interesting change. I would be smaller again if we didn't have the @supports but this is fine (and correct) so let's merge it!
RobinMalfait
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.