Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symbols from create spoken forms & migrate to *.talon-list #1638

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3028ae3
Remove symbols from create spoken forms & migrate remaining keys list…
knausj85 Dec 14, 2024
057eb2d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 14, 2024
6bce77c
Update create_spoken_forms.py
knausj85 Dec 14, 2024
f291cbf
Merge branch 'create-spoken-form-remote-symbols' of https://github.co…
knausj85 Dec 14, 2024
ee47ffb
Update test_create_spoken_forms.py
knausj85 Dec 14, 2024
eadc481
Update create_spoken_forms.py
knausj85 Dec 14, 2024
47e2ddf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 14, 2024
d01743f
Update create_spoken_forms.py
knausj85 Dec 14, 2024
1e30068
preserve set functionality to remove duplicates, fix unit tests.
knausj85 Dec 14, 2024
0762dfa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 14, 2024
052047c
Remove duplicates
knausj85 Dec 15, 2024
f8db161
Merge branch 'main' into create-spoken-form-remote-symbols
nriley Dec 15, 2024
3559a73
Merge branch 'main' into create-spoken-form-remote-symbols
nriley Dec 15, 2024
8848939
Update create_spoken_forms.py
knausj85 Jan 19, 2025
2e270a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 19, 2025
cebcb50
Update test_create_spoken_forms.py
knausj85 Jan 19, 2025
b134361
Merge branch 'create-spoken-form-remote-symbols' of https://github.co…
knausj85 Jan 19, 2025
61d69b3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 19, 2025
775115d
Update create_spoken_forms.py
knausj85 Jan 19, 2025
bf534e5
Merge branch 'create-spoken-form-remote-symbols' of https://github.co…
knausj85 Jan 19, 2025
cb7829e
Merge branch 'main' into create-spoken-form-remote-symbols
knausj85 Jan 19, 2025
7ec878a
Update symbol_key.talon-list
knausj85 Jan 25, 2025
99c2f7f
Merge branch 'main' into create-spoken-form-remote-symbols
knausj85 Jan 25, 2025
78fbfcc
Merge branch 'main' into create-spoken-form-remote-symbols
nriley Jan 25, 2025
59ff70e
Merge branch 'main' into create-spoken-form-remote-symbols
nriley Jan 28, 2025
a480e62
Merge branch 'main' into create-spoken-form-remote-symbols
nriley Feb 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Dec 14, 2024
commit 057eb2d7cc7c2a175582c397f0b7b16aa48e62bc
4 changes: 1 addition & 3 deletions core/create_spoken_forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,9 +458,7 @@ def create_spoken_forms(
) -> list[str]:
"""Create spoken forms for a given source"""

spoken_forms = create_spoken_forms_from_regex(
source, REGEX_NO_SYMBOLS
)
spoken_forms = create_spoken_forms_from_regex(source, REGEX_NO_SYMBOLS)

# only generate the subsequences if requested
if generate_subsequences:
Expand Down
2 changes: 0 additions & 2 deletions core/keys/keys.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,3 @@ def keys(m) -> str:
def letters(m) -> str:
"Multiple letter keys"
return "".join(m.letter_list)


Loading