feat: add user setting for hiss debounce time #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is far too short for me and kept triggering if I uttered "say something" or "sentence Something", or any other sibilant sentence.
BlueDrink9
force-pushed
the
settings
branch
2 times, most recently
from
ca037a9 to
b993162
Compare
for more information, see https://pre-commit.ci
knausj85
reviewed
Jan 25, 2025
| @@ -31,7 +38,10 @@ def noise_trigger_hiss_debounce(active: bool): | |||
| """Since the hiss noise triggers while you're talking we need to debounce it""" | |||
| global hiss_cron | |||
| if active: | |||
| hiss_cron = cron.after("100ms", lambda: actions.user.noise_trigger_hiss(active)) | |||
| hiss_cron = cron.after( | |||
| str(settings.get("user.hiss_scroll_debounce_time")) + "ms", | |||
There was a problem hiding this comment.
I'd suggest using an F-string maybe, but otherwise looks good to me
Suggested change
| str(settings.get("user.hiss_scroll_debounce_time")) + "ms", | |
| f"{settings.get("user.hiss_scroll_debounce_time")}ms", |
There was a problem hiding this comment.
hm I thought we had flynt running automatically in CI to do that
There was a problem hiding this comment.
f-string would be nicer than explicitly converting, true. I originally wanted to be more explicit about the ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is far too short for me and kept triggering if I uttered "say something" or "sentence Something", or any other sibilant sentence.