Merge pull request canjs#485 from bitovi/renderer-consistency-485

Issue: can.view.ejs(str) and can.view.ejs(id, str) return different responses
tamzinblake · Oct 14, 2013 · 55c06f2 · 55c06f2
2 parents d41f222 + a082ced
commit 55c06f2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/view/view.js b/view/view.js
@@ -669,8 +669,7 @@ steal("can/util", function( can ) {
 					return renderer;
 				}
 
-				$view.preload(id, info.renderer(id, text));
-				return can.view(id);
+				return $view.preload(id, info.renderer(id, text));
 			}
 		},
 		registerScript: function( type, id, src ) {

diff --git a/view/view_test.js b/view/view_test.js
@@ -704,4 +704,16 @@
 		equal(div.getElementsByTagName("h3")[0].innerHTML, 'Hi test',
 			'Got expected test from extensionless template');
 	});
+
+	test("can.view[engine] always returns fragment renderers (#485)", 2, function() {
+		var template = "<h1>{{message}}</h1>";
+		var withId = can.view.mustache('test-485', template);
+		var withoutId = can.view.mustache(template);
+
+		ok(withoutId({ message: 'Without id'}) instanceof DocumentFragment,
+			'View without id returned document fragment');
+
+		ok(withId({ message: 'With id'}) instanceof DocumentFragment,
+			'View with id returned document fragment');
+	});
 })();