remix the mix; and default globals for standalone #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallytalwar
reviewed
Sep 27, 2017
themes/bubble-wrap-icons.yaml
Outdated
| styles: | ||
| mapzen_icon_library: | ||
| base: points | ||
| texture: mapzen_icon_library | ||
| # To make Refill's colorize-able icons play nice with other styles | ||
| mix: # intentionally blank, is parsed as null (no mix) | ||
| mix: global.sdk_icon_color_style |
There was a problem hiding this comment.
Hmm one does not need to specify this. The style property merging process will make sure to get the mix property from an import.
There was a problem hiding this comment.
The same will apply to all other base style (other PRs).
There was a problem hiding this comment.
Got it. Fixed in 36315b8 and all the other PRs have also been updated.
All the example imports in the blog post still work!
tallytalwar
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.