Merge pull request liquality#249 from liquality/remove-translations

fix: move translations out of error-parser

.changeset/light-avocados-lie.md

@@ -0,0 +1,5 @@
+---
+'@liquality/error-parser': patch
+---
+
+fix: move translations out of error-parser - translation strings should be in the clients that use them

packages/error-parser/src/LiqualityErrors/LiqualityError.ts

@@ -1,10 +1,10 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import randomBytes = require('randombytes');
 import { JSONObject } from '../types';
-import { ERROR_ID_LENGTH } from '../config';
-import { PLACEHOLDER, PLAIN } from './translations/translationKeys';
+import { ERROR_ID_LENGTH, TRANSLATION_KEYS } from '../config';
 import { LIQUALITY_ERROR_STRING_STARTER } from '../utils';
 
+const { PLAIN, PLACEHOLDER } = TRANSLATION_KEYS;
 export abstract class LiqualityError<Context extends JSONObject = JSONObject> extends Error {
   source: string;
   translationKey: string;

packages/error-parser/src/LiqualityErrors/ThirdPartyError.ts

@@ -1,6 +1,8 @@
-import { ERROR_NAMES } from '../config';
+import { ERROR_NAMES, TRANSLATION_KEYS } from '../config';
 import { LiqualityError, UserActivity } from './LiqualityError';
-import { PLAIN, SWAP_ACTIVITY, UNKNOWN_ACTIVITY } from './translations/translationKeys';
+
+const { PLAIN, PLACEHOLDER, SWAP_ACTIVITY, UNKNOWN_ACTIVITY } = TRANSLATION_KEYS;
+
 export class ThirdPartyError extends LiqualityError<ThirdPartyErrorContext> {
   reportable = true;
 
@@ -12,7 +14,7 @@ export class ThirdPartyError extends LiqualityError<ThirdPartyErrorContext> {
     this.translationKey = `${this.name}.${PLAIN}`;
 
     if (data?.activity === UserActivity.SWAP) {
-      this.translationKey = `${this.name}.${PLAIN}.${SWAP_ACTIVITY}`;
+      this.translationKey = `${this.name}.${PLACEHOLDER}.${SWAP_ACTIVITY}`;
     } else {
       this.translationKey = `${this.name}.${PLAIN}.${UNKNOWN_ACTIVITY}`;
     }