Skip to content

Commit

Permalink
chore: fix frontend directory structure
Browse files Browse the repository at this point in the history
  • Loading branch information
vividvilla committed May 27, 2019
1 parent 0911742 commit 11ca4be
Show file tree
Hide file tree
Showing 35 changed files with 41 additions and 48 deletions.
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
frontend/node_modules/
frontend/my/node_modules/
frontend/.cache/
frontend/yarn.lock
frontend/my/yarn.lock
.vscode/

config.toml
config.toml
14 changes: 7 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
BIN := listmonk
STATIC := config.toml.sample schema.sql queries.sql public email-templates frontend/my/build:/frontend
STATIC := config.toml.sample schema.sql queries.sql public email-templates frontend/build:/frontend

HASH := $(shell git rev-parse --short HEAD)
COMMIT_DATE := $(shell git show -s --format=%ci ${HASH})
Expand All @@ -8,20 +8,20 @@ VERSION := ${HASH} (${COMMIT_DATE})

.PHONY: build-frontend
build-frontend:
cd frontend/my && yarn install && yarn build
cd frontend && yarn install && yarn build

.PHONY: quickdev
quickdev:
@ if [ ! -d "frontend/my/node_modules" ]; then \
@ if [ ! -d "frontend/node_modules" ]; then \
echo "Installing frontend deps"; \
cd frontend/my && yarn install; \
cd frontend && yarn install; \
fi

@ if [ ! -d "frontend/my/build" ]; then \
@ if [ ! -d "frontend/build" ]; then \
echo "Creating build directory"; \
mkdir -p frontend/my/build; \
mkdir -p frontend/build; \
echo "Building frontend assets"; \
cd frontend/my && yarn build; \
cd frontend && yarn build; \
fi

@ echo -e "\nBuilding go binary\n"
Expand Down
2 changes: 1 addition & 1 deletion README.dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ There are two independent components, the Go backend and the React frontend. In

### 2. Run the frontend

`cd frontend/my` and `yarn start`
`cd frontend` and `yarn start`

### 3. Setup an Nginx proxy endpoint

Expand Down
1 change: 1 addition & 0 deletions frontend/.babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
"presets": ["env", "react"],
"plugins": [["transform-react-jsx", { "pragma": "h" }]]
}

File renamed without changes.
File renamed without changes.
File renamed without changes.
34 changes: 0 additions & 34 deletions frontend/my/package.json

This file was deleted.

32 changes: 30 additions & 2 deletions frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,34 @@
{
"name": "my",
"version": "0.1.0",
"private": true,
"dependencies": {
"create-react-app": "^1.5.2",
"react": "^16.4.1"
"antd": "^3.6.5",
"axios": "^0.18.0",
"bizcharts": "^3.2.5-beta.4",
"dayjs": "^1.7.5",
"react": "^16.4.1",
"react-app-rewire-less": "^2.1.3",
"react-app-rewired": "^1.6.2",
"react-dom": "^16.4.1",
"react-quill": "^1.3.1",
"react-router": "^4.3.1",
"react-router-dom": "^4.3.1",
"react-scripts": "1.1.4"
},
"scripts": {
"start": "react-app-rewired start",
"build": "GENERATE_SOURCEMAP=false PUBLIC_URL=/frontend/ react-app-rewired build",
"test": "react-app-rewired test --env=jsdom",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": "react-app"
},
"devDependencies": {
"babel-plugin-import": "^1.11.0",
"eslint-plugin-prettier": "^3.0.1",
"less-plugin-npm-import": "^2.1.0",
"prettier": "1.15.3"
}
}
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes.
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func initFileSystem(binPath string) (stuffbin.FileSystem, error) {

// The frontend app's static assets are aliased to /frontend
// so that they are accessible at localhost:port/frontend/static/ ...
"frontend/my/build:/frontend",
"frontend/build:/frontend",
}

fs, err = stuffbin.NewLocalFS("/", files...)
Expand Down

0 comments on commit 11ca4be

Please sign in to comment.