fix(indexer): fixes inability to serialize Connection because of Arc. (…

…#1253)

Description
---

Removes an Arc in Connection type.

Motivation and Context
---

With Arc type can't derive Serialize trait implementation.

How Has This Been Tested?
---

CI tests.

What process can a PR reviewer use to test or verify this change?
---


Breaking Changes
---

- [x] None
- [ ] Requires data directory to be deleted
- [ ] Other - Please specify

applications/tari_indexer/src/json_rpc/handlers.rs

@@ -20,7 +20,7 @@
 //   WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
 //   USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-use std::{collections::HashMap, fmt::Display, sync::Arc};
+use std::{collections::HashMap, fmt::Display, ops::Deref, sync::Arc};
 
 use axum_jrpc::{
     error::{JsonRpcError, JsonRpcErrorReason},
@@ -252,7 +252,7 @@ impl JsonRpcHandlers {
                 },
                 age: conn.age(),
                 ping_latency: conn.ping_latency,
-                user_agent: conn.user_agent,
+                user_agent: conn.user_agent.map(|arc| arc.deref().clone()),
             })
             .collect();
 

clients/tari_indexer_client/src/types.rs

@@ -1,7 +1,7 @@
 //   Copyright 2023 The Tari Project
 //   SPDX-License-Identifier: BSD-3-Clause
 
-use std::{sync::Arc, time::Duration};
+use std::time::Duration;
 
 use multiaddr::Multiaddr;
 use serde::{Deserialize, Serialize};
@@ -457,7 +457,7 @@ pub struct Connection {
     pub age: Duration,
     #[cfg_attr(feature = "ts", ts(type = "{secs: number, nanos: number} | null"))]
     pub ping_latency: Option<Duration>,
-    pub user_agent: Option<Arc<String>>,
+    pub user_agent: Option<String>,
 }
 
 #[derive(Serialize, Debug)]