Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transactions)!: adds versioned transaction schema #1223

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Dec 23, 2024

Description

fix(transactions)!: adds versioned transaction schema
Updated bindings (1.2.0), walletd client (1.2.0) and web UIs
Fix clippies in latest stable rust

Motivation and Context

Allows us to make versioned changes to the transaction schema/model while still supporting older schemas.

V1 may include breaking changes until mainnet.

How Has This Been Tested?

Manually, existing tests

What process can a PR reviewer use to test or verify this change?

Should work as before

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Dec 23, 2024

Test Results (CI)

572 tests   - 21   572 ✅  - 21   1h 13m 58s ⏱️ - 2h 17m 55s
 54 suites  - 12     0 💤 ± 0 
  1 files    -  1     0 ❌ ± 0 

Results for commit 415f52a. ± Comparison against base commit dadfd5d.

This pull request removes 22 and adds 1 tests. Note that renamed tests count towards both.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:88:3
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:9:3
Scenario: Concurrent calls to the Counter template: tests/features/concurrency.feature:7:3
Scenario: Confidential transfer to unexisting account: tests/features/transfer.feature:160:3
Scenario: Counter template registration and invocation multiple times: tests/features/counter.feature:48:3
Scenario: Counter template registration and invocation once: tests/features/counter.feature:8:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:8:3
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:130:3
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:81:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:48:3
…
tari_transaction ‑ v1::export_bindings_transactionv1

♻️ This comment has been updated with latest results.

@sdbondi sdbondi force-pushed the transactions-versioning branch 3 times, most recently from 643197c to 39be78c Compare December 23, 2024 11:08
@sdbondi sdbondi force-pushed the transactions-versioning branch from 39be78c to 5ebacb5 Compare December 23, 2024 11:20
@sdbondi
Copy link
Member Author

sdbondi commented Dec 23, 2024

The Web UI is failing to compile because the bindings are not published

@sdbondi sdbondi merged commit 361eb2e into tari-project:development Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants