feat!: add change metadata to encrypted data

[hansieodendaal]

Description

• Added receiver address, amount, and payment ID to encrypted data so a view-only wallet can identify the receiver when importing a change output.
• Fixed payment ID not propagated for interactive transactions.
• Added payment ID to burn transactions.
• Edit Removed message from transactions - payment ID is now used consistently throughout

Note: Burn transaction status for change outputs needs to be fixed, see #6726

Motivation and Context

Change data needs to be available for wallet recovery. This is especially useful for view-only wallets.

How Has This Been Tested?

System-level testing

one-sided

• Sender wallet, one-sided
  

• Receiver wallet, one-sided
  

• View-only wallet, one-sided
  

interactive

• Sender wallet, interactive
  

• Receiver wallet, interactive
  

• View-only wallet, interactive
  

burn

• Sender wallet, burn
  

• View-only wallet, burn
  

What process can a PR reviewer use to test or verify this change?

Code review
System-level testing

Breaking Changes

• None
• Requires data directory on base node to be deleted
• Requires hard fork
• Other - Please specify

BREAKING CHANGE:

• Console wallet command line arguments:
  • --message is not supported anymore, only --payment-id
• Wallet FFI:
  • fn completed_transaction_get_message( removed
  • fn pending_outbound_transaction_get_message( removed
  • fn pending_outbound_transaction_get_payment_id( added
  • fn pending_inbound_transaction_get_message( removed
  • fn pending_inbound_transaction_get_payment_id( added
  • fn wallet_send_transaction( has interface change
• Wallet gRPC methods:
  • message CreateBurnTransactionRequest { has interface change
  • message PaymentRecipient { has interface change
  • message TransactionInfo { has interface change
  • message CoinSplitRequest { has interface change
  • message ImportUtxosRequest { has interface change
  • message TransactionEvent { has interface change
  • message RegisterValidatorNodeRequest { has interface change

[github-actions]

Test Results (CI)

    3 files    129 suites   36m 11s ⏱️
1 349 tests 1 349 ✅ 0 💤 0 ❌
4 045 runs  4 045 ✅ 0 💤 0 ❌

Results for commit d54da49.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

36 tests  +36   36 ✅ +36   15m 20s ⏱️ + 15m 20s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit d54da49. ± Comparison against base commit 37c30be.

♻️ This comment has been updated with latest results.

[SWvheerden]

Although this PR moves in the right direction there are a few issues here:
1: Payment_id != message. There can be a message inside the payment_id, but its very much user data(message) + system level data. We need to keep separation between the two. This PR completely merges it and makes it all user data. Looking at the data I suspect there might have been some regression in terms of display here.

2: On the transmission of the data, the sender should not and can not control what the receiver pputs in his/her output. So no use in sending anything like that over. That data is sent over, but never actually used in the output. Interactive payments should keep using only the message. Dont add payment id for the receiver there.

3: On the display, we should not just display the raw data on the transactions.
For example on the view only wallet. It should not display the incoming data. It should display output going transaction for that amount. Not incoming. It should be more clever how it creates the transaction. It should read the details from the payment id field to create the outgoing tx. It should look almost similar to the spending wallet

4: This is a regression by the looks of it, but we should not display default addresses. We should self, or something like that there.

[SWvheerden]

think is can go in like this for now

[SWvheerden]

II think this one should probably also display nothing, but its fine for now