Skip to content

Commit

Permalink
fix(ui): new animation build + additionalBrowserArgs (#823)
Browse files Browse the repository at this point in the history
Description
---

- added new webgl animation build:
  - updated `three` to `r169` and replaced a deprecated function
- has the BG colour changes baked into the build so could remove it from
our index.html
- added `additionalBrowserArgs` with `ignore-gpu-blocklist` enabled and
`disable-accelerated-2d-canvas` disabled to hopefully prevent the WEBGL
context errors we've been getting

Motivation and Context
---
- trying to bring down the amount of WebGl errors (lots to be seen on
sentry)

What process can a PR reviewer use to test or verify this change?
---
- if you had been getting the `"THREE.WebGLRenderer: Error creating
WebGL context."` console error previously, you (hopefully:D) shouldn't
see it now
- if you can't run this locally to check then if we can find your
machine on sentry relating to that error + confirm it doesn't come up
any longer

---------

Co-authored-by: Brian Pearce <[email protected]>
  • Loading branch information
shanimal08 and brianp authored Oct 14, 2024
1 parent 2c5bd07 commit 91b6604
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 54 deletions.
3 changes: 0 additions & 3 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
time = performance.now() / 1000;
window.addEventListener('resize', onResize);

glApp.properties.bgColor1 = '#F6F6F6';
glApp.properties.bgColor2 = '#EEEEEE';

onResize();
animate();
}
Expand Down
98 changes: 48 additions & 50 deletions public/assets/glApp.js

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src-tauri/tauri.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@
"resizable": true,
"fullscreen": false,
"decorations": true,
"transparent": false
"transparent": false,
"additionalBrowserArgs": "--enable-features=ignore-gpu-blocklist, --disable=features=disable-accelerated-2d-canvas"
}
],
"security": {
Expand Down

0 comments on commit 91b6604

Please sign in to comment.