-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: version bump 0.8.28 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Add AIRDROP_WEBSOCKET envs in CI
First static UI build for the main SoS Leaderboard modal. I still have some more work to do on it but the Leaderboard and Crew UI elements are ready to be integrated. It should be safe to merge this anytime, this UI can only be accessed through the Admin UI modal. ![CleanShot 2024-12-09 at 19 12 41](https://github.com/user-attachments/assets/44ed3961-9f8b-448a-ae25-dd56526a8562) ![CleanShot 2024-12-16 at 20 46 05](https://github.com/user-attachments/assets/d880a974-9227-4d86-a3fa-b831bd94661e) --------- Co-authored-by: Juan De Luca <[email protected]> Co-authored-by: Juan <[email protected]> Co-authored-by: stringhandler <[email protected]>
This is a small optimization to the Settings modal. In my opinion, we don't need animation here. By removing the animation, it makes the UI feel "snappy" and this should perform better when other elements cause performance issues. The user experience goal of the Settings section is to provide users with access to these more advanced settings as quickly and smoothly as possible. The timing of the animations actually slows access down and gets in the way of the optimal experience. https://www.loom.com/share/38ff2cda3b9641dba7dde2488a56e015
#1208 Description -- Disabled p2pool flag wasn't stored in store since user could close/reopen p2pool stats and crash the app after switching it on. Testing -- 1. Run app with p2pool disabled 2. Enable p2pool mining, cancel restarting 3. Close and reopen settings view 4. App shouldn't crash
Description --- Seeing errors in Sentry where the main window can't be fetched. Retry for a second before panic'ing. Motivation and Context --- A brief delay between window creation and closing may help alleviate the error. How Has This Been Tested? --- Error isn't present locally so 🤞🏻
Description Release notes Motivation and Context --- How Has This Been Tested? Locally What process can a PR reviewer use to test or verify this change? Merge and test <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description Update translations Motivation and Context i18n How Has This Been Tested? Locally What process can a PR reviewer use to test or verify this change? Release Notes is a newly translated section, for example. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onwards and upwards