fix(ui): removed X logo from claim gems and possible linux click fix #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peps
requested review from
PanchoBubble,
stringhandler,
brianp and
shanimal08
brianp
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "X" logo from the
Claim Gemsbutton in the login modal. This is because we now support multi-auth logins.I also added
preventDefaultandstopPropagationto see if it fixes an issue where this button is not working on Linux. I don't have access to a Linux machine to test, so this is a shot in the dark fix. This is low risk though, since adding those event functions shouldn't effect anything on the working platforms.