Skip to content

Commit

Permalink
Fixed data beyond column Z bug
Browse files Browse the repository at this point in the history
  • Loading branch information
jsonkenl committed Sep 22, 2016
1 parent e7a17b9 commit b8090ea
Show file tree
Hide file tree
Showing 26 changed files with 77 additions and 106 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## 1.3.5

- Fixed bug where unnecessary cells with `nil` values were added to worksheets with rows containing data beyond column `"Z"`.

## 1.3.4

- Fixed bug related to parsing a worksheet containing conditional formatting. Thanks to Justin Nauman (@jrnt30) for contribution.
Expand Down
2 changes: 1 addition & 1 deletion OVERVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ You can add Xlsxir as a dependancy to your Elixir project via the Hex package ma

```elixir
def deps do
[ {:xlsxir, "~> 1.3.4"} ]
[ {:xlsxir, "~> 1.3.5"} ]
end
```

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ You can add Xlsxir as a dependancy to your Elixir project via the Hex package ma

```elixir
def deps do
[ {:xlsxir, "~> 1.3.4"} ]
[ {:xlsxir, "~> 1.3.5"} ]
end
```

Expand Down
6 changes: 2 additions & 4 deletions doc/404.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>404 – Xlsxir v1.3.4</title>
<title>404 – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/404.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="extras">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.Codepoint.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Codepoint – Xlsxir v1.3.4</title>
<title>Xlsxir.Codepoint – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.Codepoint.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.Codepoint


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.ConvertDate.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ConvertDate – Xlsxir v1.3.4</title>
<title>Xlsxir.ConvertDate – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.ConvertDate.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.ConvertDate


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.Index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Index – Xlsxir v1.3.4</title>
<title>Xlsxir.Index – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.Index.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.Index


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.ParseString.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ParseString – Xlsxir v1.3.4</title>
<title>Xlsxir.ParseString – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.ParseString.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.ParseString


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.ParseStyle.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ParseStyle – Xlsxir v1.3.4</title>
<title>Xlsxir.ParseStyle – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.ParseStyle.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.ParseStyle


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.ParseWorksheet.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ParseWorksheet – Xlsxir v1.3.4</title>
<title>Xlsxir.ParseWorksheet – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.ParseWorksheet.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.ParseWorksheet


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.SaxParser.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.SaxParser – Xlsxir v1.3.4</title>
<title>Xlsxir.SaxParser – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.SaxParser.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.SaxParser


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.SharedString.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.SharedString – Xlsxir v1.3.4</title>
<title>Xlsxir.SharedString – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.SharedString.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.SharedString


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.Style.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Style – Xlsxir v1.3.4</title>
<title>Xlsxir.Style – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.Style.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.Style


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.TableId.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.TableId – Xlsxir v1.3.4</title>
<title>Xlsxir.TableId – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.TableId.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.TableId


Expand Down
8 changes: 3 additions & 5 deletions doc/Xlsxir.Timer.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Timer – Xlsxir v1.3.4</title>
<title>Xlsxir.Timer – Xlsxir v1.3.5</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<link rel="canonical" href="https://hexdocs.pm/xlsxir/Xlsxir.Timer.html" />

<script src="dist/sidebar_items.js"></script>
</head>
<body data-type="modules">
Expand All @@ -30,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.4
v1.3.5
</h2>
</div>

Expand Down Expand Up @@ -62,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.4</small>
<small class="visible-xs">Xlsxir v1.3.5</small>
Xlsxir.Timer


Expand Down
Loading

0 comments on commit b8090ea

Please sign in to comment.