Skip to content

Commit

Permalink
Fixed year 1900 bug
Browse files Browse the repository at this point in the history
  • Loading branch information
jsonkenl committed Jul 26, 2016
1 parent fe3ede9 commit c9989e6
Show file tree
Hide file tree
Showing 26 changed files with 90 additions and 93 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## 1.3.2

- Fixed bug where dates in the year 1900 were off by one day due to the fact that Excel erroneously considers the year 1900 a leap year.
- Minor documentation updates.

## 1.3.1

- Fixed issue where empty cells were skipped. Empty cells will now be represented as `nil`. For example, if cells "A1" = 1, "B1" = 2, and "D1" = 4, `Xlsxir.get_list/1` would return `[[1, 2, 4]]`. The same situation will now return `[[1, 2, nil, 4]]` to account for the fact that cell "C1" was empty.
Expand Down
2 changes: 1 addition & 1 deletion OVERVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ You can add Xlsxir as a dependancy to your Elixir project via the Hex package ma

```elixir
def deps do
[ {:xlsxir, "~> 1.3.1"} ]
[ {:xlsxir, "~> 1.3.2"} ]
end
```

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ You can add Xlsxir as a dependancy to your Elixir project via the Hex package ma

```elixir
def deps do
[ {:xlsxir, "~> 1.3.1"} ]
[ {:xlsxir, "~> 1.3.2"} ]
end
```

Expand Down
4 changes: 2 additions & 2 deletions doc/404.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>404 – Xlsxir v1.3.1</title>
<title>404 – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.Codepoint.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Codepoint – Xlsxir v1.3.1</title>
<title>Xlsxir.Codepoint – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.Codepoint


Expand Down
8 changes: 4 additions & 4 deletions doc/Xlsxir.ConvertDate.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ConvertDate – Xlsxir v1.3.1</title>
<title>Xlsxir.ConvertDate – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.ConvertDate


Expand Down Expand Up @@ -140,7 +140,7 @@ <h1 class="section-heading">
</a>
<span class="signature">convert_char_number(number)</span>

<a href="https://github.com/kennellroxco/xlsxir/blob/master/lib/xlsxir/convert_date.ex#L95" class="view-source" rel="help" title="View Source">
<a href="https://github.com/kennellroxco/xlsxir/blob/master/lib/xlsxir/convert_date.ex#L97" class="view-source" rel="help" title="View Source">
<i class="icon-code"></i>
</a>

Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.Index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Index – Xlsxir v1.3.1</title>
<title>Xlsxir.Index – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.Index


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.ParseString.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ParseString – Xlsxir v1.3.1</title>
<title>Xlsxir.ParseString – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.ParseString


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.ParseStyle.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ParseStyle – Xlsxir v1.3.1</title>
<title>Xlsxir.ParseStyle – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.ParseStyle


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.ParseWorksheet.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.ParseWorksheet – Xlsxir v1.3.1</title>
<title>Xlsxir.ParseWorksheet – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.ParseWorksheet


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.SaxParser.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.SaxParser – Xlsxir v1.3.1</title>
<title>Xlsxir.SaxParser – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.SaxParser


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.SharedString.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.SharedString – Xlsxir v1.3.1</title>
<title>Xlsxir.SharedString – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.SharedString


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.Style.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Style – Xlsxir v1.3.1</title>
<title>Xlsxir.Style – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.Style


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.TableId.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.TableId – Xlsxir v1.3.1</title>
<title>Xlsxir.TableId – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.TableId


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.Timer.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Timer – Xlsxir v1.3.1</title>
<title>Xlsxir.Timer – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.Timer


Expand Down
6 changes: 3 additions & 3 deletions doc/Xlsxir.Unzip.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="ExDoc v0.11.5">
<title>Xlsxir.Unzip – Xlsxir v1.3.1</title>
<title>Xlsxir.Unzip – Xlsxir v1.3.2</title>
<link rel="stylesheet" href="dist/app-f9b4ee049e.css" />

<script src="dist/sidebar_items.js"></script>
Expand All @@ -28,7 +28,7 @@ <h1 class="sidebar-projectName">
Xlsxir
</h1>
<h2 class="sidebar-projectVersion">
v1.3.1
v1.3.2
</h2>
</div>

Expand Down Expand Up @@ -60,7 +60,7 @@ <h2 class="sidebar-projectVersion">


<h1>
<small class="visible-xs">Xlsxir v1.3.1</small>
<small class="visible-xs">Xlsxir v1.3.2</small>
Xlsxir.Unzip


Expand Down
Loading

0 comments on commit c9989e6

Please sign in to comment.