Skip to content

Commit

Permalink
Added secondary instrumentation because statsd is not dimensional
Browse files Browse the repository at this point in the history
  • Loading branch information
lonelycode committed Dec 24, 2016
1 parent 0ed5b08 commit 940be24
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions middleware.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ func CreateMiddleware(mw TykMiddlewareImplementation, tykMwSuper *TykMiddleware)

if confErr != nil {
log.Fatal("[Middleware] Configuration load failed")
//handler := ErrorHandler{tykMwSuper}
//handler.HandleError(w, r, confErr.Error(), 403)
}

aliceHandler := func(h http.Handler) http.Handler {
Expand All @@ -67,7 +65,9 @@ func CreateMiddleware(mw TykMiddlewareImplementation, tykMwSuper *TykMiddleware)
"size": strconv.Itoa(int(r.ContentLength)),
"mw_name": mw.GetName(),
}
eventName := mw.GetName() + "." + "executed"
job.EventKv("executed", meta)
job.EventKv(eventName, meta)
startTime := time.Now()

if (tykMwSuper.Spec.CORS.OptionsPassthrough) && (r.Method == "OPTIONS") {
Expand All @@ -79,6 +79,7 @@ func CreateMiddleware(mw TykMiddlewareImplementation, tykMwSuper *TykMiddleware)
handler.HandleError(w, r, reqErr.Error(), errCode)
meta["error"] = reqErr.Error()
job.TimingKv("exec_time", time.Since(startTime).Nanoseconds(), meta)
job.TimingKv(eventName+".exec_time", time.Since(startTime).Nanoseconds(), meta)
return
}

Expand All @@ -88,6 +89,7 @@ func CreateMiddleware(mw TykMiddlewareImplementation, tykMwSuper *TykMiddleware)
log.Info("[Middleware] Received stop code")
meta["stopped"] = "1"
job.TimingKv("exec_time", time.Since(startTime).Nanoseconds(), meta)
job.TimingKv(eventName+".exec_time", time.Since(startTime).Nanoseconds(), meta)
return
}

Expand All @@ -99,6 +101,7 @@ func CreateMiddleware(mw TykMiddlewareImplementation, tykMwSuper *TykMiddleware)
}

job.TimingKv("exec_time", time.Since(startTime).Nanoseconds(), meta)
job.TimingKv(eventName+".exec_time", time.Since(startTime).Nanoseconds(), meta)
}

}
Expand Down
2 changes: 1 addition & 1 deletion version.go
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
package main
var VERSION string = "v2.3.0.40"
var VERSION string = "v2.3.0.41"

0 comments on commit 940be24

Please sign in to comment.