Add a lint for certain suspicious trait object usage #264
Conversation
|
|
thomcc
force-pushed
the
thomcc/sus-trait-obj
branch
from
8ee6642 to
fc274e0
Compare
| hir::ItemKind::Union(_, generics) => *generics, | ||
| hir::ItemKind::Trait(_, _, generics, ..) => *generics, | ||
| hir::ItemKind::Fn(_, generics, ..) => *generics, | ||
| _ => return, |
There was a problem hiding this comment.
Same remark as before.
Though, I'm surprised you can't leverage OpaqueTy somehow to induce this problem. Or can you and we already check that?
There was a problem hiding this comment.
OpaqueTy is unstable, it's TAIT stuff.
There was a problem hiding this comment.
Rather, using OpaqueTy in a turbofish or default type requires TAIT.
There was a problem hiding this comment.
Ohhh, I misread rustc's docs and lost the type Foo = part, thought for some reason that all impl Trait goes through it.
There was a problem hiding this comment.
Oh oh oh, so wait... wait... OpaqueTy is a threat but it's currently syntactically inaccessible in this position, right?
There was a problem hiding this comment.
I'm actually not sure that struct/enum/type/... are a threat in the first place. They're easy to check for and it feels like I almost got it working, so I figured I'd check for them.
But yeah, TraitAlias is probably in the same position. I could put it here too, but this whole thing probably needs rethinking when those stabilize
There was a problem hiding this comment.
I've filed #270 about this kind of thing.
No description provided.