Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to use github.sha instead of github.ref #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md to use github.sha instead of github.ref #143

wants to merge 1 commit into from

Conversation

Jamesking56
Copy link

#48 (comment)

This comment says its better to use github.sha rather than github.ref so we should really tell people to start with that in the Readme.

@tclindner
Copy link
Owner

Hey @Jamesking56 does our current comment/note cover this already?

image

@Jamesking56
Copy link
Author

The comment is good however the main example of using ${{ github.ref }} just causes the step to fail by default.

I'd rather the default examples are working as a straight drop-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jamesking56 @tclindner