fix(express-type): changed TApp type #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5869bfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 91.17% 91.14% -0.03%
==========================================
Files 12 12
Lines 306 305 -1
Branches 80 80
==========================================
- Hits 279 278 -1
Misses 18 18
Partials 9 9
|
tdeekens
reviewed
Oct 23, 2020
|
done! |
tdeekens
reviewed
Oct 23, 2020
tdeekens
approved these changes
Oct 24, 2020
Merged
|
Sorry!, I was not available on the weekend 👎 , thanks! |
natoehv
added a commit
to natoehv/promster
that referenced
this pull request
Oct 26, 2020
* fix(express-type): changed TApp type * chore(express-type): added four-pigs-relax.md * Update four-pigs-relax.md Co-authored-by: Renato Hormazabal <[email protected]> Co-authored-by: Tobias Deekens <[email protected]>
|
The fix worked for you? |
|
yes!, no errors now, thank you very much!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we use a createMiddleware TS throw an error of wrong object (Express application).
Description
Type 'Application' is missing the following properties from type 'TApp': setTimeout, maxHeadersCount, timeout, headersTimeout, and 9 more.ts(2740)solves #499