[#noissue] Fix static analysis issues

techblue · Aug 19, 2019 · eb0c602 · eb0c602
1 parent 571006d
commit eb0c602
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/tools/src/main/java/com/navercorp/pinpoint/tools/network/TCPChecker.java b/tools/src/main/java/com/navercorp/pinpoint/tools/network/TCPChecker.java
@@ -58,16 +58,13 @@ protected boolean check(InetSocketAddress address, byte[] requestData, byte[] ex
 
     private Socket createSocket(InetSocketAddress socketAddress) throws IOException {
         Socket socket = null;
-        boolean success = false;
         try {
             socket = new Socket();
             socket.setSoTimeout(3000);
             socket.connect(socketAddress);
-            success = true;
-        } finally {
-            if (!success) {
-                IOUtils.closeQuietly(socket);
-            }
+        } catch (IOException ioe){
+            IOUtils.closeQuietly(socket);
+            throw ioe;
         }
         return socket;
     }