Skip to content

Commit

Permalink
Update contributing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
sachinchoolur authored Aug 8, 2016
1 parent 073298b commit 7fc793e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ First, ensure that you have the latest [Node.js](http://nodejs.org/) and [npm](h
## Submitting pull requests
Pull requests are very welcome. Note that if you are going to propose drastic changes, be sure to open an issue for discussion first, to make sure that your PR will be accepted before you spend effort coding it.

1. Create a new branch, please don't work in your `master` branch directly.
1. Javascript changes of lightgallery plugins should be made in repective github repositoy.
2. SCSS and CSS changes should be made in lightgallery.js repository. Ex: If you want to submit a PR for lightgallery.js thumbnails plugin javacsript changes should be submitted in [lg-thumbnails.js](https://github.com/sachinchoolur/lg-thumbnail.js) repository and SCSS and CSS changes should be submitted in [lightgallery.js](https://github.com/sachinchoolur/lightgallery.js) repository.
2. Create a new branch, please don't work in your `master` branch directly.
1. Add failing tests for the change you want to make. Run `npm run build` to see the tests fail.
1. Fix stuff.
1. Run `npm run build` to see if the tests pass. Repeat steps 2-4 until done.
1. Update the documentation to reflect any changes.
2. Please do not include minified files with the pull request as i will do it myself.
1. Push to your fork and submit a pull request.

0 comments on commit 7fc793e

Please sign in to comment.