Skip to content

Commit

Permalink
dynamic_debug: deprecate ddebug_query, suggest dyndbg instead
Browse files Browse the repository at this point in the history
With ddebug_dyndbg_boot_params_cb() handling bare dyndbg params, we
dont need ddebug_query param anymore.  Add a warning when processing
ddebug_query= param that it is deprecated, and to change it to dyndbg=

Add a deprecation notice for v3.8 to feature-removal-schedule.txt, and
add a suggested deprecation period of 3 releases to the header.

Signed-off-by: Jim Cromie <[email protected]>
Acked-by: Jason Baron <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
jimc authored and gregkh committed Apr 30, 2012
1 parent b48420c commit f0b919d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 8 additions & 1 deletion Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@ The following is a list of files and features that are going to be
removed in the kernel source tree. Every entry should contain what
exactly is going away, why it is happening, and who is going to be doing
the work. When the feature is removed from the kernel, it should also
be removed from this file.
be removed from this file. The suggested deprecation period is 3 releases.

---------------------------

What: ddebug_query="query" boot cmdline param
When: v3.8
Why: obsoleted by dyndbg="query" and module.dyndbg="query"
Who: Jim Cromie <[email protected]>, Jason Baron <[email protected]>

---------------------------

Expand Down
2 changes: 2 additions & 0 deletions lib/dynamic_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,8 @@ static int __init dynamic_debug_init(void)

/* ddebug_query boot param got passed -> set it up */
if (ddebug_setup_string[0] != '\0') {
pr_warn("ddebug_query param name is deprecated,"
" change it to dyndbg\n");
ret = ddebug_exec_queries(ddebug_setup_string);
if (ret < 0)
pr_warn("Invalid ddebug boot param %s",
Expand Down

0 comments on commit f0b919d

Please sign in to comment.