Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting of ValueError if horizon_elevation is less than 0 #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjoerd-bouma
Copy link
Contributor

@sjoerd-bouma sjoerd-bouma commented Feb 7, 2025

Tiny bugfix - the error emitted if horizon_elevation < 0 (added in #25) was not formatted correctly. Weirdly, this seems not to cause any issues on Python >= 3.8 (other than presumably raising a different error instead of raising the ValueError), but it seems Python <= 3.7 complains already at compile time, which breaks the module.

Okay, I was not familiar with this - apparently this is annotated string formatting, which was added only with Python 3.8. So this is actually just another compatibility fix for outdated Python versions : )

Copy link

what-the-diff bot commented Feb 7, 2025

PR Summary

  • Improved Error Message Presentation in Horizon Elevation Validation
    • The error message display has been updated to provide a clearer presentation of "current horizon elevation" calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant