Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowntree v5 #3055

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Dropdowntree v5 #3055

merged 5 commits into from
Dec 16, 2021

Conversation

PaskalevStoyan
Copy link
Contributor

@PaskalevStoyan PaskalevStoyan commented Dec 13, 2021

resolves: #2803 , #3059
discussion: N/A

Because the popup part of the DropDownTree component is a TreeView, some rendering changes and class renames have been made to the TreeView:

  • k-group -> k-treeview-group
  • k-top | bot | mid -> k-treeview-top | bot | mid
  • k-item -> k-treeview-item
  • k-in -> k-treeview-leaf
  • the expand / collapse icons are now wrapped in a span with a k-treeview-toggle class:
<span class="k-treeview-toggle">
  <span class="k-icon k-i-expand"></span>
</span>
<span class="k-treeview-toggle">
  <span class="k-icon k-i-collapse"></span>
</span>
  • the text of the item is now wrapped in a span with a k-treeview-leaf-text class :
  • Treeview with expand / collapse icons:
<span class="k-treeview-leaf">
  <span class="k-treeview-leaf-text"> ... </span>
</span>  
  • Treeview with custom icons:
 <span class="k-treeview-leaf">
  <span class="k-icon k-i-file"></span>
  <span class="k-treeview-leaf-text">...</span>
</span>
  • Refactor treeview markup
  • Introduce sizing options
  • refactor present treeview visual tests
  • Add kendo prefix to variables
  • refactor states
  • Add variable descriptions
  • Add tests
  • Add docs

@PaskalevStoyan PaskalevStoyan self-assigned this Dec 13, 2021
@PaskalevStoyan PaskalevStoyan force-pushed the dropdowntree-v5 branch 2 times, most recently from 486b5f3 to 0c9914a Compare December 13, 2021 16:58
@PaskalevStoyan PaskalevStoyan marked this pull request as ready for review December 13, 2021 16:58
@Juveniel
Copy link
Contributor

@PaskalevStoyan we need a separate tracking issue for the TreeView, where the rendering changes are described.

Copy link
Contributor

@joneff joneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of issues, but we can merge and fix later.

@joneff joneff merged commit 4ba93b2 into v5-dev Dec 16, 2021
@joneff joneff deleted the dropdowntree-v5 branch December 16, 2021 16:54
@joneff joneff added this to the 2022.1 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants