Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Commit

Permalink
Fix serialized classNames for Optimizers (#1861)
Browse files Browse the repository at this point in the history
BUG
INTERNAL
  • Loading branch information
davidsoergel authored Jul 29, 2019
1 parent 341a8be commit 03c205e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/optimizers/adadelta_optimizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {Optimizer, OptimizerVariable} from './optimizer';
/** @doclink Optimizer */
export class AdadeltaOptimizer extends Optimizer {
/** @nocollapse */
static className = 'AdadeltaOptimizer';
static className = 'Adadelta'; // Name matters for Python compatibility.
private accumulatedGrads: OptimizerVariable[] = [];
private accumulatedUpdates: OptimizerVariable[] = [];

Expand Down
2 changes: 1 addition & 1 deletion src/optimizers/momentum_optimizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {SGDOptimizer} from './sgd_optimizer';
/** @doclink Optimizer */
export class MomentumOptimizer extends SGDOptimizer {
/** @nocollapse */
static className = 'MomentumOptimizer';
static className = 'Momentum'; // Name matters for Python compatibility.
private m: Scalar;
private accumulations: OptimizerVariable[] = [];

Expand Down
2 changes: 1 addition & 1 deletion src/optimizers/rmsprop_optimizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {Optimizer, OptimizerVariable} from './optimizer';
/** @doclink Optimizer */
export class RMSPropOptimizer extends Optimizer {
/** @nocollapse */
static className = 'RMSProp';
static className = 'RMSProp'; // Note: Name matters for Python compatibility.
private centered: boolean;

private accumulatedMeanSquares: OptimizerVariable[] = [];
Expand Down
2 changes: 1 addition & 1 deletion src/optimizers/sgd_optimizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {Optimizer} from './optimizer';
/** @doclink Optimizer */
export class SGDOptimizer extends Optimizer {
/** @nocollapse */
static className = 'SGD'; // Name matters for Python compatibility.
static className = 'SGD'; // Note: Name matters for Python compatibility.
protected c: Scalar;

constructor(protected learningRate: number) {
Expand Down

0 comments on commit 03c205e

Please sign in to comment.