Set up targeting idle eth cores on BH - won't enable because of hang debug #14817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhullar-tt
requested review from
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
approved these changes
Nov 6, 2024
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
from
3b0ff59 to
259a471
Compare
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
from
259a471 to
d9c8f61
Compare
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
2 times, most recently
from
8f95992 to
5ef063a
Compare
abhullar-tt
changed the title
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
2 times, most recently
from
3c8dc89 to
f11c6b5
Compare
abhullar-tt
changed the title
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
4 times, most recently
from
34fc134 to
778dc55
Compare
3 tasks
blozano-tt
reviewed
Dec 4, 2024
blozano-tt
reviewed
Dec 4, 2024
blozano-tt
reviewed
Dec 4, 2024
blozano-tt
reviewed
Dec 4, 2024
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
from
778dc55 to
7c23c0a
Compare
pgkeller
approved these changes
Dec 4, 2024
| @@ -74,6 +74,8 @@ HalCoreInfoType create_active_eth_mem_map() { | |||
| .fw_base_addr = eth_l1_mem::address_map::FIRMWARE_BASE, | |||
| .local_init_addr = eth_l1_mem::address_map::FIRMWARE_BASE, // this will be uplifted in subsequent commits | |||
| // enabling active erisc | |||
| .fw_launch_addr = 0xFFB14008, | |||
| .fw_launch_addr_value = (uint32_t)eth_l1_mem::address_map::FIRMWARE_BASE, | |||
There was a problem hiding this comment.
minor: wasn't clear what "fw_launch_addr_value" was in other contexts, maybe "fw_launch_jmp_insn" (yes, ties the use to the name, but I think that's ok)
There was a problem hiding this comment.
hm the reason I didn't add jump into the name is because we don't always write the jump instruction at this value. like this case above we just write FW base addr directly to the PC
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
from
7c23c0a to
8460546
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
3 times, most recently
from
9ade451 to
de63dbe
Compare
… the HalJitBuildConfig
abhullar-tt
force-pushed
the
abhullar/enable-bh-eth
branch
from
de63dbe to
34b61de
Compare
abhullar-tt
changed the title
ubcheema
approved these changes
Jan 10, 2025
aliuTT
approved these changes
Jan 10, 2025
| @@ -145,7 +145,7 @@ static void RunTest(WatcherFixture* fixture, IDevice* device) { | |||
| k_id_s = ""; | |||
| } | |||
| expected = fmt::format( | |||
| "Device {} ethnet core(x={:2},y={:2}) virtual(x={:2},y={:2}): {}, X, X, X, X rmsg:* " | |||
| "Device {} ethnet core(x={:2},y={:2}) virtual(x={:2},y={:2}): {}, {}, X, X, X rmsg:* " | |||
There was a problem hiding this comment.
I saw this in a couple places in debug_tools folder, I think thats the shorthand used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #14653
No ticket, removing workaround required that was impacting p100 CI
What's changed
CI FW has been downgraded so this going back to original behaviour
09/01/25 This PR was updated to not enable BH eth cores because of a hang when running dispatch out of idle eth + async FD. This is being debugged separately and once it has been root-caused/worked around will enable targeting eth cores.
Checklist
Old CI when eth cores were enabled
09/01/25 CI without enabling eth cores