#16339: parameterize dispatch_constants #16355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhuang-tt
force-pushed
the
nhuang/parameterize-fd
branch
2 times, most recently
from
667bf31 to
f4ecd39
Compare
- Add DispatchSettings - Add DispatchConstants. Struct with only static constexpr values. Later to remove those values from dispatch_constants which is doing memory/address layout calculations - Put align methods into helper file - Some namespace pollution reduced
nhuang-tt
force-pushed
the
nhuang/parameterize-fd
branch
from
f4ecd39 to
26c2625
Compare
nhuang-tt
commented
Dec 31, 2024
|
|
||
| // FIXME: Don't do this in header files | ||
| using namespace tt::tt_metal; | ||
|
|
||
| namespace tt::tt_metal { | ||
|
|
||
| // todo consider moving these to dispatch_addr_map | ||
| static constexpr uint32_t MAX_HUGEPAGE_SIZE = 1 << 30; // 1GB; |
There was a problem hiding this comment.
Moved these to DispatchConstants
nhuang-tt
requested review from
ubcheema,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma and
tt-asaigal
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#16339
Problem description
Parameterize dispatch constants
What's changed
Add DispatchSettings
Add DispatchConstants. Struct with only static constexpr values. Later to remove those values from dispatch_constants which is doing memory/address layout calculations
Put align methods into helper file
Some namespace pollution reduced
Checklist
https://github.com/tenstorrent/tt-metal/actions/runs/12555971563
https://github.com/tenstorrent/tt-metal/actions/runs/12543433572