Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero return imports, and support for result types #726

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix zero return imports, and support for result types #726

wants to merge 4 commits into from

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Feb 22, 2025 •
edited
Loading

  • Bumped tool versions of erlang and elixir, hope that's ok
  • Added package.json and company to gitignore
  • Functions with no return values were not working correctly, added the native code changes to support this use case.
  • Result types were not being mapped when running running an export. Wire this and added some test coverage.

The imports test already had most of what I needed so seemed like a good idea to add more cases to it.

@mangas mangas force-pushed the fix-zero-return-imports branch from be2c553 to d1bf0ba Compare February 22, 2025 22:49
@mangas
Copy link
Contributor Author

mangas commented Feb 28, 2025

Hey @tessi, just in case you missed the PR, can I get a review on this when you get the chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mangas