Skip to content

ci: expand matrix to include Node 22 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
main:
# ignore all-contributors PRs
if: ${{ !contains(github.head_ref, 'all-contributors') }}
name: Node ${{ matrix.node }}, Svelte ${{ matrix.svelte }}, ${{ matrix.check }}
name: Svelte ${{ matrix.svelte }}, Node ${{ matrix.node }}, ${{ matrix.check }}
runs-on: ubuntu-latest

# enable OIDC for codecov uploads
Expand All @@ -27,20 +27,22 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18', '20']
svelte: ['3', '4']
node: ['16', '18', '20', '22']
svelte: ['3', '4', '5']
check: ['test:vitest:jsdom', 'test:vitest:happy-dom', 'test:jest']
exclude:
# Don't run Svelte 3 on Node versions greater than 20
- { svelte: '3', node: '22' }
# Only run Svelte 5 on Node versions greater than or equal to 20
- { svelte: '5', node: '16' }
- { svelte: '5', node: '18' }
include:
# We only need to lint once, so do it on latest Node and Svelte
- { node: '20', svelte: '4', check: 'lint' }
# Run type checks in latest node
- { node: '20', svelte: '3', check: 'types:legacy' }
- { node: '20', svelte: '4', check: 'types:legacy' }
- { node: '20', svelte: '5', check: 'types' }
# Only run Svelte 5 checks on latest Node
- { node: '20', svelte: '5', check: 'test:vitest:jsdom' }
- { node: '20', svelte: '5', check: 'test:vitest:happy-dom' }
- { node: '20', svelte: '5', check: 'test:jest' }
- { svelte: '5', node: '22', check: 'lint' }
# Run type checks in latest applicable Node
- { svelte: '3', node: '20', check: 'types:legacy' }
- { svelte: '4', node: '22', check: 'types:legacy' }
- { svelte: '5', node: '22', check: 'types' }

steps:
- name: ⬇️ Checkout repo
Expand Down